Skip to content

TidyContact: Allow defining what EN page types it can run on#372

Merged
fernanDOTdo merged 2 commits into
mainfrom
tc-pagefilter
Mar 13, 2026
Merged

TidyContact: Allow defining what EN page types it can run on#372
fernanDOTdo merged 2 commits into
mainfrom
tc-pagefilter

Conversation

@StoneMoney

Copy link
Copy Markdown
Member

This update adds an additional option field page_types that allow client themes to specify what EN page types TidyContact should run on. When a page type is not on this allowlist a "TidyContact is disabled on this page type" is printed via the logger.

Expected behaviors:

Config Setting Page Type Runs?
[] * YES
undefined, unset, etc. (Backwards-Compatability) * YES
["DONATION"] DONATION YES
["DONATION"] SUBSCRIBEFORM NO
["DONATION","SUBSCRIBEFORM"] DONATION YES
["DONATION","SUBSCRIBEFORM"] SUBSCRIBEFORM YES

Test pages, uploaded from a branch with the config set to ["DONATION"]:
DONATION Page - https://act.ran.org/page/90802/donate/1?assets=tc-pagetypes-test&debug=log (TC should run)
SUBSCRIBEFORM Page - https://act.ran.org/page/55579/subscribe/1?assets=tc-pagetypes-test&debug=log (TC should not run)

Associated task: https://app.productive.io/2650-4site-interactive-studios-inc/tasks/15508244

@StoneMoney
StoneMoney marked this pull request as draft January 28, 2026 20:02
@StoneMoney
StoneMoney marked this pull request as ready for review February 10, 2026 16:07
@fernanDOTdo
fernanDOTdo merged commit ab45234 into main Mar 13, 2026
2 checks passed
@fernanDOTdo
fernanDOTdo deleted the tc-pagefilter branch March 13, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants